Re: [PATCH 2/3] dt-bindings: net: at803x: Document at803x,smarteee-disabled property

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 1/25/19 4:55 AM, Carlo Caione wrote:
> SmartEEE is a proprietary protocol that allows legacy MAC/SoC devices
> without 802.3az support to function as a complete 802.3az system.
> 
> This is know to cause issues so a new property is added to optionally
> disable this feature.
> 
> Signed-off-by: Carlo Caione <ccaione@xxxxxxxxxxxx>
> ---
>  .../devicetree/bindings/net/at803x.txt         | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/net/at803x.txt
> 
> diff --git a/Documentation/devicetree/bindings/net/at803x.txt b/Documentation/devicetree/bindings/net/at803x.txt
> new file mode 100644
> index 000000000000..931cb34534fb
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/at803x.txt
> @@ -0,0 +1,18 @@
> +* Atheros AR803x Integrated 10/100/1000 Mbps Ethernet Transceiver
> +
> +Required properties:
> +	- reg - The ID number for the phy, usually a small integer
> +
> +Optional property:
> +	- at803x,smarteee-disabled: Disable SmartEEE feature

Should this be named at803x,smarteee-broken instead of "disabled"?
Because disabled is effectively what will happen after the driver looks
up that property and acts on it, but this does not really describe the
HW state unless there is appropriate software running.

Similar question to Heiner, how do SmartEEE and standard EEE relate to
each other? Can we use the existing broken-eee properties?

> +
> +Example:
> +
> +	ethernet-phy@0 {
> +		compatible = "ethernet-phy-ieee802.3-c22";
> +		reg = <0>;
> +		at803x,smarteee-disabled
> +	};
> +
> +Datasheet can be found:
> +https://media.digikey.com/pdf/Data%20Sheets/CSR%20PDFs/AR8031_DS_(Atheros)_Rev1.0_Aug2011.pdf
> 


-- 
Florian



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux