Hello Mark, Thanks again for looking through my changes =) On Wed, Jan 23, 2019 at 03:51:21PM +0000, Mark Brown wrote: > On Tue, Jan 22, 2019 at 11:43:28AM +0200, Matti Vaittinen wrote: > > Header rohm-bd718x7.h was split to generic and component specific > > parts. This changed the struct bd718x7. Adapt the regulator driver to > > these changes. > > Acked-by: Mark Brown <broonie@xxxxxxxxxx> > > Does this need to be squashed into the earlier commit for bisection? Yes. If we don't want to break the compilation between commits then the patches 2, 3 and 4 should be squashed into one. I sent them as separare changes for easier review. I can squash them and send them squashed if they are Ok to Lee and Stephen. Please just let me know whose tree I should use as the basis so I can do rebasing if needed. (Or is there some better way to do changes like this?) Br, Matti Vaittinen -- Matti Vaittinen ROHM Semiconductors ~~~ "I don't think so," said Rene Descartes. Just then, he vanished ~~~