Re: [PATCH v2 02/10] usb: host: xhci: mvebu: add reset on resume quirk

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Gregory,

Gregory CLEMENT <gregory.clement@xxxxxxxxxxx> wrote on Fri, 18 Jan 2019
17:04:01 +0100:

> Hi Miquel,
>  
>  On ven., janv. 11 2019, Miquel Raynal <miquel.raynal@xxxxxxxxxxx> wrote:
> 
> > From: Ofer Heifetz <oferh@xxxxxxxxxxx>
> >
> > The mvebu xHCI host driver does not have suspend/resume support. Use of
> > the XHCI_RESET_ON_RESUME quirk is mandatory in order to avoid failures
> > after resume. This will work only if no USB device is plugged-in.
> >
> > While at it, mention in the Kconfig file that this IP is also present
> > on the A3700 SoC.
> >
> > Signed-off-by: Ofer Heifetz <oferh@xxxxxxxxxxx>
> > [miquel.raynal@xxxxxxxxxxx: Reword the commit message]
> > Signed-off-by: Miquel Raynal <miquel.raynal@xxxxxxxxxxx>
> > ---
> >  drivers/usb/host/Kconfig      |  4 ++--
> >  drivers/usb/host/xhci-mvebu.c | 11 +++++++++++
> >  drivers/usb/host/xhci-mvebu.h |  6 ++++++
> >  drivers/usb/host/xhci-plat.c  |  7 +++++++
> >  4 files changed, 26 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
> > index 16758b12a5e9..13d59be6a6aa 100644
> > --- a/drivers/usb/host/Kconfig
> > +++ b/drivers/usb/host/Kconfig
> > @@ -69,13 +69,13 @@ config USB_XHCI_MTK
> >  	  If unsure, say N.
> >  
> >  config USB_XHCI_MVEBU
> > -	tristate "xHCI support for Marvell Armada 375/38x"
> > +	tristate "xHCI support for Marvell Armada 375/38x/3700"  
> 
> I would name it 37xx to be consistent with 38x
> 
> >  	select USB_XHCI_PLATFORM
> >  	depends on HAS_IOMEM
> >  	depends on ARCH_MVEBU || COMPILE_TEST
> >  	---help---
> >  	  Say 'Y' to enable the support for the xHCI host controller
> > -	  found in Marvell Armada 375/38x ARM SOCs.
> > +	  found in Marvell Armada 375/38x/3700 ARM SOCs.  
> same here
> 

Sure!


Thanks,
Miquèl



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux