Hi Miquel, On 2019/1/16 0:52, Miquel Raynal wrote: > Hi Jianxin, > > Jianxin Pan <jianxin.pan@xxxxxxxxxxx> wrote on Tue, 15 Jan 2019 > 23:38:02 +0800: > >> These two patches try to add initial NAND driver support for Amlogic Meson >> SoCs, current it has been tested on GXL(p212) and AXG(s400) platform. >> >> Changes since V8 at [9] >> - fix build failre at object_is_on_stack >> - update Kconfig as Martin's suggested > > Thanks for this last version, looks good to me. Could you please send a > patch to add a MAINTAINERS entry? > OK. > Also, can we face any deadly failure if someone compiles this driver > without the MMC clock driver updated? > Without the MMC clock driver 1) This driver can be built successfully. 2) The probe will fail when get clocks defined in MMC clock driver. > Thanks, > Miquèl > > . >