Hi Michael, On 1/18/19 2:37 PM, Michael Tretter wrote: > This is v2 of the series to add support for the Allegro DVT H.264 encoder > found in the EV family of the Xilinx ZynqMP platform. > > See v1 [0] of the patch series for a description of the hardware. > > I fixed the handling of frames with various sizes and driver is now able to > encode H.264 video in the baseline profile up to 1920x1080 pixels. I also > addressed the issues reported by the kbuild robot for the previous series, > implemented a few extended controls and changed the interface to the mcu to > follow the register documentation rather than the downstream driver > implementation. > > I would especially appreciate feedback to the device tree bindings and the > overall architecture of the driver. I'll try to review this next week. Ping me if you didn't see a review by the end of next week. BTW, can you post the output of 'v4l2-compliance -s'? (make sure you use the very latest version of v4l2-compliance!) Regards, Hans > > The driver still only works with the vcu-firmware release 2018.2. I am not yet > sure how to address the different firmware versions, because in addition to > the mailbox sizes, there are also changes within the messages themselves. > > I also did not address the integration with the xlnx-vcu driver, yet. > > Michael > > [0] https://lore.kernel.org/linux-media/20190109113037.28430-1-m.tretter@xxxxxxxxxxxxxx/ > > Changes since v1: > - clean up debug log levels > - fix unused variable in allegro_mbox_init > - fix uninitialized variable in allegro_mbox_write > - fix global module parameters > - fix Kconfig dependencies > - return h264 as default codec for mcu > - implement device reset as documented > - document why irq does not wait for clear > - rename ENCODE_ONE_FRM to ENCODE_FRAME > - allow error codes for mcu_channel_id > - move control handler to channel > - add fw version check > - add support for colorspaces > - enable configuration of H.264 levels > - enable configuration of frame size > - enable configuration of bit rate and CPB size > - enable configuration of GOP size > - rework response handling > - fix missing error handling in allegro_h264_write_sps > > Michael Tretter (3): > media: dt-bindings: media: document allegro-dvt bindings > [media] allegro: add Allegro DVT video IP core driver > [media] allegro: add SPS/PPS nal unit writer > > .../devicetree/bindings/media/allegro.txt | 35 + > MAINTAINERS | 6 + > drivers/staging/media/Kconfig | 2 + > drivers/staging/media/Makefile | 1 + > drivers/staging/media/allegro-dvt/Kconfig | 16 + > drivers/staging/media/allegro-dvt/Makefile | 6 + > .../staging/media/allegro-dvt/allegro-core.c | 2828 +++++++++++++++++ > drivers/staging/media/allegro-dvt/nal-h264.c | 1278 ++++++++ > drivers/staging/media/allegro-dvt/nal-h264.h | 188 ++ > 9 files changed, 4360 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/allegro.txt > create mode 100644 drivers/staging/media/allegro-dvt/Kconfig > create mode 100644 drivers/staging/media/allegro-dvt/Makefile > create mode 100644 drivers/staging/media/allegro-dvt/allegro-core.c > create mode 100644 drivers/staging/media/allegro-dvt/nal-h264.c > create mode 100644 drivers/staging/media/allegro-dvt/nal-h264.h >
