On Thu, Jan 10, 2019 at 7:54 PM Da Xue <da@xxxxxxxxxxxxxxxx> wrote: > > Hi, > > To be on the safe side, I would add the PCB revision number and WiFi module name. my PCB states: Q5X2 V3.0 18393 > Most of the WiFi modules are from Fn link so simply denoting the AP6356S may be sufficient to distinguish future PCB revisions and wireless modules. our .dtbs mostly don't care about the WiFi chip (because it can be auto-detected using the SDIO ID). however, Bluetooth support on these modules is different because a different WiFi / Bluetooth combo chip manufacturer also means different dt-bindings regarding the .dts name so far we have: - meson-g12a-x96-max.dts and your suggestions: - meson-g12a-x96-max-ap6356s.dts - meson-g12a-x96-max-3.0-ap6356s.dts Regards Martin
