On Tue 15 Jan 08:27 PST 2019, Sai Prakash Ranjan wrote: > Hi Bjorn, > > Thanks for the review. Please find my comments inline. > > On 1/13/2019 12:53 PM, Bjorn Andersson wrote: > > On Wed 09 Jan 09:46 PST 2019, Sai Prakash Ranjan wrote: > > > > > Add coresight components found on Qualcomm SDM845 SoC. > > > > > > Signed-off-by: Sai Prakash Ranjan <saiprakash.ranjan@xxxxxxxxxxxxxx> > > > > Hi Sai, > > > > The content of this patch looks good, but please fold it into > > sdm845.dtsi (keep the nodes sorted by address). > > > > I had looked at the sample from hi6220 for coresight and > decided to keep sdm845 coresight dtsi in separate file as it > would look much cleaner than mixing it with main dtsi file. > Also I guess it would make coresight topology more understandable > if we keep it separately (plus there are about 400+ lines of coresight > dt entries). Is there any reason for wanting coresight entries merged > into sdm845.dtsi file? If you still prefer it, I can make the > change in the next version. > There seems to be some variations of this, but we try to keep everything sorted in sdm845.dtsi to avoid having to jump around between the various files. So please merge it into sdm845.dtsi (sorted by address). Regards, Bjorn > > And mention below the --- that this depends on my AMBA bus pclk change > > and include the URL: > > > > https://lore.kernel.org/lkml/20190106080915.4493-7-bjorn.andersson@xxxxxxxxxx/ > > > > I had mentioned this dependency in the cover letter. But I suppose > I can mention it here as well. > > Thanks, > Sai > > -- > QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member > of Code Aurora Forum, hosted by The Linux Foundation
