On Thu, Jan 03, 2019 at 05:41:01PM +0100, Thomas Petazzoni wrote: > This commit adds support for configuring the pull-up and pull-down > resistors available in some GPIO controllers. While configuring > pull-up/pull-down is already possible through the pinctrl subsystem, > some GPIO controllers, especially simple ones such as GPIO expanders > on I2C, don't have any pinmuxing capability and therefore do not use > the pinctrl subsystem. > > This commit implements the GPIO_PULL_UP and GPIO_PULL_DOWN flags, > which can be used from the Device Tree, to enable a pull-up or > pull-down resistor on a given GPIO. > > The flag is simply propagated all the way to the core GPIO subsystem, > where it is used to call the gpio_chip ->set_config callback with the > appropriate existing PIN_CONFIG_BIAS_* values. > > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@xxxxxxxxxxx> > --- > drivers/gpio/gpiolib-of.c | 5 +++++ > drivers/gpio/gpiolib.c | 12 ++++++++++++ > drivers/gpio/gpiolib.h | 2 ++ > include/dt-bindings/gpio/gpio.h | 6 ++++++ It's fine, but really this one should be part of the binding patch. > include/linux/gpio/machine.h | 2 ++ > include/linux/of_gpio.h | 2 ++ > 6 files changed, 29 insertions(+) Acked-by: Rob Herring <robh@xxxxxxxxxx>
