On Fri, Jan 11, 2019 at 1:58 PM Thomas Petazzoni <thomas.petazzoni@xxxxxxxxxxx> wrote: > On Fri, 11 Jan 2019 11:05:03 +0100, Linus Walleij wrote: > > > +/* Bit 4 express pull up */ > > > +#define GPIO_PULL_UP 16 > > > + > > > +/* Bit 5 express pull down */ > > > +#define GPIO_PULL_DOWN 32 > > > > Please use > > #define GPIO_PULL_UP BIT(5) > > #define GPIO_PULL_DOWN BIT(6) (...) > However, we are in the dt-bindings includes here, and apparently, there > is no definition for the BIT() macro in those headers. Ah you nailed it :D OK keep it like this. Yours, Linus Walleij
