Hello Martin,
Am 21.12.18 um 10:29 schrieb kernel@xxxxxxxxxxxxxxxx:
> From: Martin Sperl <kernel@xxxxxxxxxxxxxxxx>
>
> This patchset adds a driver for the mcp25xxfd CanFD controller.
>
> Most of the features of the controller are supported by this driver
> release.
>
> The controller includes a few features that the current core Can(FD)
> implementation does not support: * Transmit Bandwidth Sharing bits
> - this waits for a configurable number of syncronization bits before
> atempting to transmit the next frame - for the moment controllable
> via a module parameter
> * SID11 with CanFD frames
> - at this moment not supported by driver
> * 3 transmit attempts in addition to ONE_SHOT
> * transmitter delay compensation configurations
> * micro second exact transmission and reception timestamps
> - used internally by driver
> * variable number of tx-fifos
> - exposed via module parameter at this moment
>
> The driver has not been heavily optimized yet so there are a few
> "low hanging fruit" that have been left out from earlier versions
> of the patch set for sake of simplicity.
>
> These optimizations shall be added as extra patches in a later cycle.
I applied all four patches adding:
$ wc -l drivers/net/can/spi/mcp25xxfd/*
5 drivers/net/can/spi/mcp25xxfd/Kconfig
11 drivers/net/can/spi/mcp25xxfd/Makefile
1204 drivers/net/can/spi/mcp25xxfd/mcp25xxfd_base.c
803 drivers/net/can/spi/mcp25xxfd/mcp25xxfd_can.c
479 drivers/net/can/spi/mcp25xxfd/mcp25xxfd_can_fifo.c
760 drivers/net/can/spi/mcp25xxfd/mcp25xxfd_can.h
723 drivers/net/can/spi/mcp25xxfd/mcp25xxfd_can_int.c
208 drivers/net/can/spi/mcp25xxfd/mcp25xxfd_can_rx.c
824 drivers/net/can/spi/mcp25xxfd/mcp25xxfd_can_tx.c
199 drivers/net/can/spi/mcp25xxfd/mcp25xxfd_gpio.c
279 drivers/net/can/spi/mcp25xxfd/mcp25xxfd.h
5495 insgesamt
Do I understand you correctly, this is the basic driver and the
optimizations are not yet included!? Well, I expected less code than
last time but now it's spit up in smaller files, at least. Will try to
do a review this week...
Wolfgang.
