Hi,
On Wed, Nov 28, 2018 at 2:34 PM Evan Green <evgreen@xxxxxxxxxxxx> wrote:
> +&sdhc_2 {
> + status = "okay";
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&sdc2_clk &sdc2_cmd &sdc2_data &sd_cd_odl>;
> +
> + vmmc-supply = <&vreg_l21a_2p95>;
> + vqmmc-supply = <&vddpx_2>;
> +
> + cd-gpios = <&tlmm 126 GPIO_ACTIVE_LOW>;
> +};
> +
> &qupv3_id_1 {
Please sort alphabetically. "s" comes after "q".
> + /* It seems that mmc_test reports errors if drive strength is not 16. */
Possibly put this comment right next to one of the the "drive-strength" lines?
> + sd_cd_odl: sd-cd-odl {
"sd_cd_odl" is the name on a different board. On sdm845 this is
'sd_card_det_n", so it'd be better to use that name.
> + pinmux {
> + pins = "gpio126";
> + function = "gpio";
> + };
> +
> + pinconf {
> + pins = "gpio126";
> + bias-pull-up;
> + drive-strength = <2>;
Maybe leave this off? According to Bjorn's research "drive-strength"
has no affect on inputs and this is most certainly an input.
-Doug
