Hi, On Wed, Nov 28, 2018 at 2:34 PM Evan Green <evgreen@xxxxxxxxxxxx> wrote: > > Add the SD controller to SDM845. > > Signed-off-by: Evan Green <evgreen@xxxxxxxxxxxx> > --- > > arch/arm64/boot/dts/qcom/sdm845.dtsi | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) Looks right to me. Possibly you might want to make it known in the subject and description that this is only sdhc_2 since there are two SD controllers in SDM845 (oddly numbered sdc2 and sdc4 in the documentation). sdc2 (the one you're supporting here) is the dual-voltage one (supports higher speeds) and also the only one hooked up on MTP I think. ...so maybe nobody will ever use sdhc_4, but it might be worth mentioning anyway. ;-) Other than that suggestion this looks good to me. [note to Andy: please double-check that this ends up in the right sort order when applying. If you happen to apply the Quad SPI patch first then "git am" might end up putting the SDHC_2 node _after_ the Quad SPI but it should sort numerically before it] Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>
