RE: [PATCH v11 01/27] iommu/exynos: do not include removed header

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




> From: Sachin Kamat [mailto:sachin.kamat@xxxxxxxxxx]
> Sent: Friday, March 14, 2014 7:00 PM
> 
> On 14 March 2014 10:31, Cho KyongHo <pullip.cho@xxxxxxxxxxx> wrote:
> > Commit 25e9d28d92 (ARM: EXYNOS: remove system mmu initialization from
> > exynos tree) removed arch/arm/mach-exynos/mach/sysmmu.h header without
> > removing remaining use of it from exynos-iommu driver, thus causing a
> > compilation error.
> >
> > This patch fixes the error by removing respective include line
> > from exynos-iommu.c.
> >
> > CC: Tomasz Figa <t.figa@xxxxxxxxxxx>
> > Signed-off-by: Cho KyongHo <pullip.cho@xxxxxxxxxxx>
> > ---
> >  drivers/iommu/exynos-iommu.c |    3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c
> > index 0740189..4876d35 100644
> > --- a/drivers/iommu/exynos-iommu.c
> > +++ b/drivers/iommu/exynos-iommu.c
> > @@ -12,6 +12,7 @@
> >  #define DEBUG
> >  #endif
> >
> > +#include <linux/kernel.h>
> 
> This change doesn't look related to the patch subject/description.
> 
Yes. But it is simply added without any side-effect.
Do you think it should be in a separate patch?.
Actually, the added line is a redundant.

Regards,

KyongHo.

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux