Best Regards! Anson Huang > -----Original Message----- > From: Alexandre Belloni [mailto:alexandre.belloni@xxxxxxxxxxx] > Sent: 2018年11月28日 17:34 > To: Anson Huang <anson.huang@xxxxxxx> > Cc: Lothar Wa��mann <LW@xxxxxxxxxxxxxxxxxxx>; a.zummo@xxxxxxxxxxxx; > robh+dt@xxxxxxxxxx; mark.rutland@xxxxxxx; catalin.marinas@xxxxxxx; > will.deacon@xxxxxxx; Aisheng DONG <aisheng.dong@xxxxxxx>; Andy Gross > <andy.gross@xxxxxxxxxx>; arnd@xxxxxxxx; horms+renesas@xxxxxxxxxxxx; > heiko@xxxxxxxxx; bjorn.andersson@xxxxxxxxxx; enric.balletbo@xxxxxxxxxxxxx; > amit.kucheria@xxxxxxxxxx; ezequiel@xxxxxxxxxxxxx; olof@xxxxxxxxx; > shawnguo@xxxxxxxxxx; linux-rtc@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; > linux-kernel@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; > dl-linux-imx <linux-imx@xxxxxxx> > Subject: Re: [PATCH 4/4] ARM64: dts: imx: add i.MX8QXP system controller > RTC support > > On 28/11/2018 09:21:56+0000, Anson Huang wrote: > > > > This module is NOT depending on any board design, should it be > > > > enabled by > > > default in soc dtsi? > > > > Like wdog etc.. > > > > > > > > > > I guess the point is that you may not want it enabled, even if it > > > should always be working. enabling it by default would affect the RTC > ordering for example. > > > > i.MX SoCs ONLY have 1 RTC. And RTC are always enabled by default for > > all i.MX SoCs, so do we have to disable it here and enable it in board dts? > > > > I would say that most of the i.MX based boards include another RTC because > the SoC one consumes way too much power. > > Note that I don't care too much whether it is enabled by default, I was simply > explaining why you may want to disable it by default. OK, this system controller RTC is a little different, it is controlled by system controller firmware, and system controller firmware will always select the best one for its user(Linux kernel) if there are other RTCs available, so I think we can keep it enabled by default for now. Thanks. Anson. > > -- > Alexandre Belloni, Bootlin > Embedded Linux and Kernel engineering > https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbootl > in.com&data=02%7C01%7Canson.huang%40nxp.com%7C5be6d014f2a5 > 4876cc9408d65514eaf3%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C > 0%7C636789945664646785&sdata=MW0xy3cUhCLBTrEFkk4vAylxSAwB > mx1Ws6ZeEhAsdME%3D&reserved=0
