Hi, Lothar Best Regards! Anson Huang > -----Original Message----- > From: Lothar Waßmann [mailto:LW@xxxxxxxxxxxxxxxxxxx] > Sent: 2018年11月28日 17:04 > To: Anson Huang <anson.huang@xxxxxxx> > Cc: a.zummo@xxxxxxxxxxxx; alexandre.belloni@xxxxxxxxxxx; > robh+dt@xxxxxxxxxx; mark.rutland@xxxxxxx; catalin.marinas@xxxxxxx; > will.deacon@xxxxxxx; Aisheng DONG <aisheng.dong@xxxxxxx>; Andy Gross > <andy.gross@xxxxxxxxxx>; arnd@xxxxxxxx; horms+renesas@xxxxxxxxxxxx; > heiko@xxxxxxxxx; bjorn.andersson@xxxxxxxxxx; enric.balletbo@xxxxxxxxxxxxx; > amit.kucheria@xxxxxxxxxx; ezequiel@xxxxxxxxxxxxx; olof@xxxxxxxxx; > shawnguo@xxxxxxxxxx; linux-rtc@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; > linux-kernel@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; > dl-linux-imx <linux-imx@xxxxxxx> > Subject: Re: [PATCH 4/4] ARM64: dts: imx: add i.MX8QXP system controller > RTC support > > Hi, > > On Tue, 27 Nov 2018 09:41:46 +0000 Anson Huang wrote: > > Add i.MX8QXP system controller RTC support. > > > > Signed-off-by: Anson Huang <Anson.Huang@xxxxxxx> > > --- > > arch/arm64/boot/dts/freescale/imx8qxp.dtsi | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi > b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi > > index 9155d45..ef57db6 100644 > > --- a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi > > +++ b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi > > @@ -433,4 +433,8 @@ > > #size-cells = <1>; > > ranges = <0x5f000000 0x0 0x5f000000 0x1000000>; > > }; > > + > > + rtc: rtc { > > + compatible = "nxp,imx8qxp-sc-rtc"; > > + }; > > }; > IMO this should be disabled by default. This module is NOT depending on any board design, should it be enabled by default in soc dtsi? Like wdog etc.. Anson. > > > Lothar Waßmann
