> > On Sat, 17 Nov 2018 18:24:03 +0100 > Lorenzo Bianconi <lorenzo.bianconi@xxxxxxxxxx> wrote: > > > > On Sat, 17 Nov 2018 09:37:54 -0600 > > > Rob Herring <robh@xxxxxxxxxx> wrote: > > > > > > > [...] > > > > > > > Optional properties: > > > > > - st,drdy-int-pin: the pin on the package that will be used to signal > > > > > "data ready" (valid values: 1 or 2). > > > > > +- st,pullups : enable/disable internal i2c controller pullup resistors. > > > > > > > > bias-pull-up is the standard property for this. > > > > > > The problem here is 'of what?'. Perhaps it wasn't clear in the current > > > binding either, but we are talking the pull ups on the auxilliary i2c bus > > > (which doesn't really have a direct representation in DT at all). > > > If we just go with bias-pull-up my instinct would be that it was applying > > > to the drdy pin for example. > > > > > > Lorenzo, could you send a follow up patch fixing this once we > > > have it pinned down? > > > > > > > Sure, it sounds good. IIUC we should use 'bias-pull-up' here, without > > vendor info, right? > Yes, though my concern about it being on it's own without any reference > points. Makes it unobvious what we are applying the pull up on. > > Jonathan > @Rob: do you agree to use 'bias-pull-up' also in this particular case? If so I will send a follow-up patch to fix it Regards, Lorenzo
