Re: [PATCH net-next v3 5/9] Altera TSE: Add Miscellaneous Files for Altera Ethernet Driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Wed, 2014-03-12 at 15:26 -0700, Joe Perches wrote:
> On Wed, 2014-03-12 at 21:14 +0000, Ben Hutchings wrote:
> > These look like the statistic names specified in IEEE 802.3.  I would
> > support a general move to using standard names for MAC stats in Ethernet
> > drivers, because they are quite clearly defined and widely implemented
> > in hardware.  However, that is not the current practice in most Linux
> > drivers.
> 
> Hey Ben.
> 
> Maybe something like this would be a start?
> 
> Change the actual #defines/strings to taste.
> 
> Maybe this shouldn't be in uapi or maybe in if_ether.h
[...]

This is pointless without also nailing down the definition of each
statistic.  That could be done with reference to standards/RFCs, of
course.

Ben.

-- 
Ben Hutchings
Experience is directly proportional to the value of equipment destroyed.
                                                         - Carolyn Scheppner

Attachment: signature.asc
Description: This is a digitally signed message part


[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux