On Tue, 2014-03-11 at 17:43 -0500, Vince Bridgers wrote:
> This patch adds miscellaneous files for the Altera Ethernet Driver,
> including ethtool support.
trivial notes:
> diff --git a/drivers/net/ethernet/altera/altera_tse_ethtool.c b/drivers/net/ethernet/altera/altera_tse_ethtool.c
[]
> +static char const stat_gstrings[][ETH_GSTRING_LEN] = {
static const char
> + "aFramesTransmittedOK",
Why the prefix with a?
> + "aFramesReceivedOK",
"rx_packets" is typically used
> + "aFramesCheckSequenceErrors",
> + "aAlignmentErrors",
> + "aOctetsTransmittedOK",
> + "aOctetsReceivedOK",
> + "aTxPAUSEMACCtrlFrames",
> + "aRxPAUSEMACCtrlFrames",
> + "ifInErrors",
> + "ifOutErrors",
> + "ifInUcastPkts",
> + "ifInMulticastPkts",
> + "ifInBroadcastPkts",
> + "ifOutDiscards",
> + "ifOutUcastPkts",
> + "ifOutMulticastPkts",
> + "ifOutBroadcastPkts",
> + "etherStatsDropEvents",
> + "etherStatsOctets",
> + "etherStatsPkts",
> + "etherStatsUndersizePkts",
> + "etherStatsOversizePkts",
> + "etherStatsPkts64Octets",
> + "etherStatsPkts65to127Octets",
> + "etherStatsPkts128to255Octets",
> + "etherStatsPkts256to511Octets",
> + "etherStatsPkts512to1023Octets",
> + "etherStatsPkts1024to1518Octets",
> + "etherStatsPkts1519toXOctets",
> + "etherStatsJabbers",
> + "etherStatsFragments",
Perhaps review all of these strings for
unusual naming.
> +static void tse_get_regs(struct net_device *dev, struct ethtool_regs *regs,
> + void *regbuf)
> +{
> + int i;
> + struct altera_tse_private *priv = netdev_priv(dev);
> + u32 *tse_mac_regs = (u32 *)priv->mac_dev;
> + u32 *buf = (u32 *)regbuf;
void * doesn't need a cast
u32 *buf = regbuf
is just fine.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
