Re: [PATCH 1/2] dt-bindings: can: rcar_canfd: document r8a77965 support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Nov 19, 2018 at 12:18:07AM +0100, Wolfram Sang wrote:
> 
> > +  - "renesas,r8a77965-canfd" for R8A77965 (R-Car M3-N) compatible controller.
> 
> Eeeks, the 'canfd' is a suffix here not a prefix :( Not your issue,
> of course. But Simon, shall we fix that for all CANFD?

I think its too late to fix it for existing bindings.
We could move to a new scheme for r8a77965 and beyond,
but that is rather messy. I lean to wards continuing with
using 'canfd' as a suffix.

> 
> > -Required properties for "renesas,r8a7795-canfd" and "renesas,r8a7796-canfd"
> > -compatible:
> > -In R8A7795 and R8A7796 SoCs, canfd clock is a div6 clock and can be used by both
> > -CAN and CAN FD controller at the same time. It needs to be scaled to maximum
> > -frequency if any of these controllers use it. This is done using the below
> > -properties:
> > +Required properties for "renesas,r8a7795-canfd", "renesas,r8a7796-canfd" and
> > +"renesas,r8a77965-canfd" compatible:
> > +In R8A7795, R8A7796 and R8A77965 SoCs, canfd clock is a div6 clock and can
> > +be used by both CAN and CAN FD controller at the same time. It needs to be
> > +scaled to maximum frequency if any of these controllers use it. This is done
> > +using the below properties:
> 
> I think updating this paragraph does not scale. Maybe we should reformat
> it the way as for plain CAN, so only in the header the new SoC gets
> added? We can fix this incrementally, though, doesn't need to be
> addressed within this patch.
> 





[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux