On Sat, Nov 17, 2018 at 8:02 AM Chen-Yu Tsai <wens@xxxxxxxx> wrote: > > On Thu, Nov 15, 2018 at 1:48 PM Vasily Khoruzhick <anarsoul@xxxxxxxxx> wrote: > > > > On Wed, Nov 7, 2018 at 11:30 PM Chen-Yu Tsai <wens@xxxxxxxx> wrote: > > > > + > > > > + speaker_amp: speaker_amp { > > > > + compatible = "simple-audio-amplifier"; > > > > + enable-gpios = <&pio 7 7 GPIO_ACTIVE_HIGH>; /* PH7 */ > > > > > > You might want to add a sound-name-prefix property. See > > > > > > Documentation/devicetree/bindings/sound/name-prefix.txt > > > > > > Also this should have a reference to its power supply regulator. > > > > You're right, it should reference its power supply which should be a > > fixed regulator controlled via GPIO from AXP803. > > > > Unfortunately there's no AXP803 GPIO support yet and > > simple-audio-amplifier doesn't have regulator property. > > > > I have no time (and interest) to work on it in near future, so if > > anyone wants to pick it up - feel free to do so. > > Understood. I can try to pick it up when I have some extra time. > > On the other hand, I tried this series on my Pine64 and (with > the necessary device tree changes) on my Bananapi M64. While > audio played (did not stall), no audio was actually coming out > of the headphones I had plugged in. I made sure that all needed > mixer controls were enabled, and the DAPM graph read all green > from the DAI to the Headphone jack. > > Any ideas? Please show output of amixer. My guess is that you don't have 'AIF1 DAC' enabled. > > Regards > ChenYu