On Wed, Nov 7, 2018 at 11:30 PM Chen-Yu Tsai <wens@xxxxxxxx> wrote:
> > +
> > + speaker_amp: speaker_amp {
> > + compatible = "simple-audio-amplifier";
> > + enable-gpios = <&pio 7 7 GPIO_ACTIVE_HIGH>; /* PH7 */
>
> You might want to add a sound-name-prefix property. See
>
> Documentation/devicetree/bindings/sound/name-prefix.txt
>
> Also this should have a reference to its power supply regulator.
You're right, it should reference its power supply which should be a
fixed regulator controlled via GPIO from AXP803.
Unfortunately there's no AXP803 GPIO support yet and
simple-audio-amplifier doesn't have regulator property.
I have no time (and interest) to work on it in near future, so if
anyone wants to pick it up - feel free to do so.
Regards,
Vasily
