On 9/11/18 11:56 AM, Chris Packham wrote: > With the addition of the invert-pwm property the adt7475 needs its own > binding documentation rather being captured under trivial-devices.txt. > > Signed-off-by: Chris Packham <chris.packham@xxxxxxxxxxxxxxxxxxx> > --- > Changes in v2: > - use pwm-polarity attiribute to indicate normal or inverted polarity. > > .../devicetree/bindings/hwmon/adt7475.txt | 24 +++++++++++++++++++ > .../devicetree/bindings/trivial-devices.txt | 4 ---- > 2 files changed, 24 insertions(+), 4 deletions(-) > create mode 100644 Documentation/devicetree/bindings/hwmon/adt7475.txt > > diff --git a/Documentation/devicetree/bindings/hwmon/adt7475.txt b/Documentation/devicetree/bindings/hwmon/adt7475.txt > new file mode 100644 > index 000000000000..d9212b5e9036 > --- /dev/null > +++ b/Documentation/devicetree/bindings/hwmon/adt7475.txt > @@ -0,0 +1,24 @@ > +*ADT7475 hwmon sensor. > + > +Required properties: > +- compatible: One of > + "adi,adt7473" > + "adi,adt7475" > + "adi,adt7476" > + "adi,adt7490" > + > +- reg: I2C address > + > +optional properties: > + > +- pwm-polarity: This configures the polarity of the PWM. 0 > + (PWM_POLARITY_NORMAL) uses logic high for 100% duty cycle. 1 > + (PWM_POLARITY_INVERSED) uses logic low for 100% duty cycle. > + > +Example: > + > +hwmon@2e { > + compatible = ; Oops. I should include a working example. I've fixed this locally but I'll hold off on sending v3 to see if there is any additional feedback. > + reg = <0x2e>; > + pwm-polarity = <1>; > +}; > diff --git a/Documentation/devicetree/bindings/trivial-devices.txt b/Documentation/devicetree/bindings/trivial-devices.txt > index 69c934aec13b..4f29100d6bbf 100644 > --- a/Documentation/devicetree/bindings/trivial-devices.txt > +++ b/Documentation/devicetree/bindings/trivial-devices.txt > @@ -14,10 +14,6 @@ ad,ad7414 SMBus/I2C Digital Temperature Sensor in 6-Pin SOT with SMBus Alert an > ad,adm9240 ADM9240: Complete System Hardware Monitor for uProcessor-Based Systems > adi,adt7461 +/-1C TDM Extended Temp Range I.C > adt7461 +/-1C TDM Extended Temp Range I.C > -adi,adt7473 +/-1C TDM Extended Temp Range I.C > -adi,adt7475 +/-1C TDM Extended Temp Range I.C > -adi,adt7476 +/-1C TDM Extended Temp Range I.C > -adi,adt7490 +/-1C TDM Extended Temp Range I.C > adi,adxl345 Three-Axis Digital Accelerometer > adi,adxl346 Three-Axis Digital Accelerometer (backward-compatibility value "adi,adxl345" must be listed too) > ams,iaq-core AMS iAQ-Core VOC Sensor >