Hi Martin, All the series [v2 / 4 patches] looks good to me. Thanks Denis -----Original Message----- From: Martin Kelly <martin@xxxxxxxxxxxxxxxx> Sent: Thursday, October 25, 2018 7:38 PM To: linux-iio@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx Cc: Lorenzo Bianconi <lorenzo.bianconi83@xxxxxxxxx>; Denis CIOCCA <denis.ciocca@xxxxxx>; Jonathan Cameron <jic23@xxxxxxxxxx>; Rob Herring <robh+dt@xxxxxxxxxx>; Martin Kelly <martin@xxxxxxxxxxxxxxxx> Subject: [PATCH v2 1/4] iio: magnetometer: add clarifying comment From: Martin Kelly <martin@xxxxxxxxxxxxxxxx> Add a comment clarifying better when to use <device_name> vs <device_name>-magn in compatibility strings. Signed-off-by: Martin Kelly <martin@xxxxxxxxxxxxxxxx> --- drivers/iio/magnetometer/st_magn_spi.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/iio/magnetometer/st_magn_spi.c b/drivers/iio/magnetometer/st_magn_spi.c index 7b7cd08fcc32..15bb09267098 100644 --- a/drivers/iio/magnetometer/st_magn_spi.c +++ b/drivers/iio/magnetometer/st_magn_spi.c @@ -23,6 +23,8 @@ * For new single-chip sensors use <device_name> as compatible string. * For old single-chip devices keep <device_name>-magn to maintain * compatibility + * For multi-chip devices, use <device_name>-magn to distinguish which + * capability is being used */ static const struct of_device_id st_magn_of_match[] = { { -- 2.11.0