On Fri, Oct 26, 2018 at 05:54:24PM +0530, Nava kishore Manne wrote: [...] > +static int zynqmp_reset_status(struct reset_controller_dev *rcdev, > + unsigned long id) > +{ > + struct zynqmp_reset_data *priv = to_zynqmp_reset_data(rcdev); > + int val, err; > + > + err = priv->eemi_ops->reset_get_status(ZYNQMP_RESET_ID + id, &val); > + if (!err) > + return err; This should be: if (err) return err; instead. Otherwise you end up always returning 0 on success ... > + > + return val; ... and uninitialized val on error. regards Philipp