> -----Original Message----- > From: Lee Jones [mailto:lee.jones@xxxxxxxxxx] > Sent: Tuesday, March 11, 2014 1:49 PM > To: Barry Song > Cc: RongJun Ying; Rob Herring; Pawel Moll; Mark Rutland; Stephen Warren; > Ian Campbell; Rob Landley; Samuel Ortiz; Grant Likely; DL-SHA- > WorkGroupLinux; Rongjun Ying; devicetree@xxxxxxxxxxxxxxx > Subject: Re: [PATCH] mfd: Support SiRF audio modules > > > > > diff --git a/include/linux/mfd/sirf/audio.h > > > > b/include/linux/mfd/sirf/audio.h new file mode 100644 index > > > > 0000000..d8cfff9 > > > > --- /dev/null > > > > +++ b/include/linux/mfd/sirf/audio.h > > > > @@ -0,0 +1,17 @@ > > > > +/* > > > > + * audio.h > > > > + * > > > > + * Copyright (c) 2014 Cambridge Silicon Radio Limited, a CSR plc > > > > +group > > > company. > > > > + * > > > > + * Licensed under GPLv2 or later. > > > > + */ > > > > > > Use a standard header please > > > > I think this has been a standard header. It is one simpler version for license. > > If there is any problem here, it should be the 1st line, we might replace > audio.h by a simple description of this file. > > My issue wasn't with the license, but the header in general. It started off > without a proper name for the driver followed by no description of the code, > then I noticed the author (who is listed at the bottom) is not mentioned. My > issue is that it's sparse and uninformative. I do think Rongjun should have a simple description instead of a "audio.h". -barry Member of the CSR plc group of companies. CSR plc registered in England and Wales, registered number 4187346, registered office Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, United Kingdom More information can be found at www.csr.com. Keep up to date with CSR on our technical blog, www.csr.com/blog, CSR people blog, www.csr.com/people, YouTube, www.youtube.com/user/CSRplc, Facebook, www.facebook.com/pages/CSR/191038434253534, or follow us on Twitter at www.twitter.com/CSR_plc. New for 2014, you can now access the wide range of products powered by aptX at www.aptx.com. ��.n��������+%������w��{.n����z�{��ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f
