> > > diff --git a/include/linux/mfd/sirf/audio.h b/include/linux/mfd/sirf/audio.h > > > new file mode 100644 > > > index 0000000..d8cfff9 > > > --- /dev/null > > > +++ b/include/linux/mfd/sirf/audio.h > > > @@ -0,0 +1,17 @@ > > > +/* > > > + * audio.h > > > + * > > > + * Copyright (c) 2014 Cambridge Silicon Radio Limited, a CSR plc group > > company. > > > + * > > > + * Licensed under GPLv2 or later. > > > + */ > > > > Use a standard header please > > I think this has been a standard header. It is one simpler version for license. > If there is any problem here, it should be the 1st line, we might replace audio.h by a simple description of this file. My issue wasn't with the license, but the header in general. It started off without a proper name for the driver followed by no description of the code, then I noticed the author (who is listed at the bottom) is not mentioned. My issue is that it's sparse and uninformative. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html