-----Original Message----- From: Fabio Estevam [mailto:festevam@xxxxxxxxx] Sent: 2018年10月19日 20:52 To: Joakim Zhang <qiangqing.zhang@xxxxxxx> Cc: Shawn Guo <shawnguo@xxxxxxxxxx>; Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>; Sascha Hauer <kernel@xxxxxxxxxxxxxx>; Fabio Estevam <fabio.estevam@xxxxxxx>; dl-linux-imx <linux-imx@xxxxxxx>; Rob Herring <robh+dt@xxxxxxxxxx>; Mark Rutland <mark.rutland@xxxxxxx>; A.s. Dong <aisheng.dong@xxxxxxx>; open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS <devicetree@xxxxxxxxxxxxxxx>; linux-kernel <linux-kernel@xxxxxxxxxxxxxxx>; moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE <linux-arm-kernel@xxxxxxxxxxxxxxxxxxx> Subject: Re: [PATCH] ARM: dts: imx6sx-sdb: Add flexcan support Hi Joakim, On Fri, Oct 19, 2018 at 6:43 AM Joakim Zhang <qiangqing.zhang@xxxxxxx> wrote: > > From: Dong Aisheng <aisheng.dong@xxxxxxx> > > CAN transceiver is different on RevA and RevB board. > It's active high on RevA while active low on Rev B. > > Signed-off-by: Dong Aisheng <aisheng.dong@xxxxxxx> > Signed-off-by: Joakim Zhang <qiangqing.zhang@xxxxxxx> > --- > arch/arm/boot/dts/imx6sx-sdb.dts | 5 ++++ > arch/arm/boot/dts/imx6sx-sdb.dtsi | 42 +++++++++++++++++++++++++++++++ > 2 files changed, 47 insertions(+) > > diff --git a/arch/arm/boot/dts/imx6sx-sdb.dts > b/arch/arm/boot/dts/imx6sx-sdb.dts > index 6dd9bebfe027..092b8de142a8 100644 > --- a/arch/arm/boot/dts/imx6sx-sdb.dts > +++ b/arch/arm/boot/dts/imx6sx-sdb.dts > @@ -10,6 +10,11 @@ > > / { > model = "Freescale i.MX6 SoloX SDB RevB Board"; > + > + /* Transceiver EN/STBY is active low on RevB board */ > + reg_can_stby: regulator-can-stby { > + gpio = <&gpio4 27 GPIO_ACTIVE_LOW>; Don't we need a gpio = <&gpio4 27 GPIO_ACTIVE_HIGH>; and also a "enable-active-high" entries in the imx6sx-sdb-reva.dts? Yes, you are right. I will add the entry in the imx6sx-sdb-reva.dts. Thanks a lot! BRs, Jaokim Zhang
