On Wed, Oct 17, 2018 at 05:18:49PM +0200, Arnd Bergmann wrote: > On Tue, Oct 16, 2018 at 5:02 AM Guo Ren <ren_guo@xxxxxxxxx> wrote: > > > > This patch adds ELF definition and module relocate codes. > > > > Signed-off-by: Guo Ren <ren_guo@xxxxxxxxx> > > Cc: Arnd Bergmann <arnd@xxxxxxxx> > > > +#ifdef __cskyBE__ > > +#define ELF_DATA ELFDATA2MSB > > +#else > > +#define ELF_DATA ELFDATA2LSB > > +#endif > > You removed support for big-endian, right? I guess the #ifdef can also > get removed here then. Aside from that, Now, we only support little-endian and it could be removed. But maybe we need support big-endian in future, so I keep it here. Best Regards Guo Ren