On Tue, Oct 16, 2018 at 5:02 AM Guo Ren <ren_guo@xxxxxxxxx> wrote: > > This patch adds ELF definition and module relocate codes. > > Signed-off-by: Guo Ren <ren_guo@xxxxxxxxx> > Cc: Arnd Bergmann <arnd@xxxxxxxx> > +#ifdef __cskyBE__ > +#define ELF_DATA ELFDATA2MSB > +#else > +#define ELF_DATA ELFDATA2LSB > +#endif You removed support for big-endian, right? I guess the #ifdef can also get removed here then. Aside from that, Reviewed-by: Arnd Bergmann <arnd@xxxxxxxx>