> On 16.10.18 07:01, Peter Chen wrote:
> > Most of NXP (Freescale) i.mx USB part has HSIC support, in this
> > series, we add support for them, it should cover all imx6 and imx7d. I
> > have no HSIC interface board which is supported by upstream kernel, so
> > this patches are only compiled ok, Frieder Schrempf, would you please
> > help me test it on your board? Thanks.
>
> Thank you for providing the patch!
> I applied it to v4.19-rc8 and tested and the LAN9730 comes up and works just fine.
>
> Here is how my devicetree looks like:
>
> usbphy_dummy: usbphy_dummy@1 {
> compatible = "usb-nop-xceiv";
> };
>
> [...]
>
> &usbh2 {
> vbus-supply = <®_usb_h2_vbus>;
> pinctrl-names = "idle", "active";
> pinctrl-0 = <&pinctrl_usbh2_idle>;
> pinctrl-1 = <&pinctrl_usbh2_active>;
> fsl,usbphy = <&usbphy_dummy>;
> phy_type = "hsic";
> status = "okay";
> #address-cells = <1>;
> #size-cells = <0>;
>
> usbnet: smsc@1 {
> compatible = "usb424,9730";
> /* Filled in by U-Boot */
> mac-address = [00 00 00 00 00 00];
> reg = <1>;
> };
> };
>
> [...]
>
> pinctrl_usbh2_idle: usbh2grp-idle {
> fsl,pins = <
> MX6QDL_PAD_RGMII_TXC__USB_H2_DATA 0x40013030
> MX6QDL_PAD_RGMII_TX_CTL__USB_H2_STROBE 0x40013030
> >;
> };
>
> pinctrl_usbh2_active: usbh2grp-active {
> fsl,pins = <
> MX6QDL_PAD_RGMII_TXC__USB_H2_DATA 0x40013030
> MX6QDL_PAD_RGMII_TX_CTL__USB_H2_STROBE 0x40017030
> >;
> };
>
>
> Are there any test cases I should try?
> How can I test suspend/resume?
>
- System suspend/resume
1. Enable USB wakeup
for i in $(find /sys -name wakeup | grep usb);do echo enabled > $i;echo "echo enabled > $i";done;
2. Let the system enter suspend using below command
echo mem > /sys/power/state
3. And see if there is a wakeup block system entering suspend, and check if USB HSIC works ok
after system resume
- Runtime suspend
1. Enable auto suspend for all USB devices, and check if USBOH3 clock is closed,
make sure do not plug any ethernet cable on the RJ45 port.
/* Enable auto suspend */
for i in $(find /sys -name control | grep usb);do echo auto > $i;echo "echo auto > $i";done;
/* Scripts to see USB clock */
root@imx8qxpmek:~# cat uclk.sh
/home/root/dump-clocks.sh | grep usb
root@imx8qxpmek:~# cat /home/root/dump-clocks.sh
#!/bin/bash
if ! mount|grep -sq '/sys/kernel/debug'; then
mount -t debugfs none /sys/kernel/debug
fi
cat /sys/kernel/debug/clk/clk_summary
2. If USB OH3 clock can close successfully, it means USB HSIC can enter suspend successfully.
3. Plug ethernet cable to see if the link can be on.
The purpose of above two tests is to see if USB HSIC can be suspended.
Thanks.
Peter
> I also have some suggestions for your patch. Please see the separate email.
>
> Thanks,
> Frieder
>
> >
> > Peter Chen (4):
> > usb: chipidea: add flag for imx hsic implementation
> > usb: chipidea: imx: add HSIC support
> > usb: chipidea: host: override ehci->hub_control
> > doc: usb: ci-hdrc-usb2: Add pinctrl properties for HSIC pin groups
> >
> > .../devicetree/bindings/usb/ci-hdrc-usb2.txt | 1 +
> > drivers/usb/chipidea/ci_hdrc_imx.c | 153 ++++++++++++++++++---
> > drivers/usb/chipidea/ci_hdrc_imx.h | 9 +-
> > drivers/usb/chipidea/host.c | 98 +++++++++++++
> > drivers/usb/chipidea/usbmisc_imx.c | 131 ++++++++++++++++++
> > include/linux/usb/chipidea.h | 3 +
> > 6 files changed, 376 insertions(+), 19 deletions(-)
> >
