Re: [PATCH 0/4] usb: chipidea: imx: add HSIC support

Frieder Schrempf <frieder.schrempf@xxxxxxxxx> · Wed, 17 Oct 2018 09:02:57 +0200

Hi Peter,

On 16.10.18 07:01, Peter Chen wrote:
Most of NXP (Freescale) i.mx USB part has HSIC support, in this series,
we add support for them, it should cover all imx6 and imx7d. I have
no HSIC interface board which is supported by upstream kernel, so this
patches are only compiled ok, Frieder Schrempf, would you please
help me test it on your board? Thanks.

Thank you for providing the patch!
I applied it to v4.19-rc8 and tested and the LAN9730 comes up and works 
just fine.

Here is how my devicetree looks like:

usbphy_dummy: usbphy_dummy@1 {
	compatible = "usb-nop-xceiv";
};

[...]

&usbh2 {
	vbus-supply = <&reg_usb_h2_vbus>;
	pinctrl-names = "idle", "active";
	pinctrl-0 = <&pinctrl_usbh2_idle>;
	pinctrl-1 = <&pinctrl_usbh2_active>;
	fsl,usbphy = <&usbphy_dummy>;
	phy_type = "hsic";
	status = "okay";
	#address-cells = <1>;
	#size-cells = <0>;

	usbnet: smsc@1 {
		compatible = "usb424,9730";
		/* Filled in by U-Boot */
		mac-address = [00 00 00 00 00 00];
		reg = <1>;
	};
};

[...]

pinctrl_usbh2_idle: usbh2grp-idle {
  fsl,pins = <
    MX6QDL_PAD_RGMII_TXC__USB_H2_DATA       0x40013030
    MX6QDL_PAD_RGMII_TX_CTL__USB_H2_STROBE  0x40013030
  >;
};

pinctrl_usbh2_active: usbh2grp-active {
  fsl,pins = <
    MX6QDL_PAD_RGMII_TXC__USB_H2_DATA       0x40013030
    MX6QDL_PAD_RGMII_TX_CTL__USB_H2_STROBE  0x40017030
  >;
};

Are there any test cases I should try?
How can I test suspend/resume?

I also have some suggestions for your patch. Please see the separate email.

Thanks,
Frieder

Peter Chen (4):
   usb: chipidea: add flag for imx hsic implementation
   usb: chipidea: imx: add HSIC support
   usb: chipidea: host: override ehci->hub_control
   doc: usb: ci-hdrc-usb2: Add pinctrl properties for HSIC pin groups

  .../devicetree/bindings/usb/ci-hdrc-usb2.txt       |   1 +
  drivers/usb/chipidea/ci_hdrc_imx.c                 | 153 ++++++++++++++++++---
  drivers/usb/chipidea/ci_hdrc_imx.h                 |   9 +-
  drivers/usb/chipidea/host.c                        |  98 +++++++++++++
  drivers/usb/chipidea/usbmisc_imx.c                 | 131 ++++++++++++++++++
  include/linux/usb/chipidea.h                       |   3 +
  6 files changed, 376 insertions(+), 19 deletions(-)