On Fri, Oct 05, 2018 at 03:47:43PM -0500, Rob Herring wrote: > On Wed, Oct 03, 2018 at 05:14:31PM -0700, Matthias Kaehlcke wrote: > > The node has a reg property, therefore its name should include a unit > > address. > > > > Also change the name from 'usb_id_nopull' to 'usb-id-nopull' to follow > > DT conventions. > > This is ADC channels? If so, then DT convention would really be > "adc@...". Is it really? A grep for 'adc@' in arch/${ARCH}/boot/dts yields mostly ADC controller not channel nodes. I'm totally fine with changing the name to 'adc@...' if that's the preference/convention, just want to reconfirm since the actual use is a bit ambiguous.