Hi Vladimir, thanks for your patch! Can we change the subject to something like "add DT bindings" rather than "add description" as it is more specific and makes it easier for me as maintainer. On Mon, Oct 8, 2018 at 11:12 PM Vladimir Zapolskiy <vz@xxxxxxxxx> wrote: > From: Vladimir Zapolskiy <vladimir_zapolskiy@xxxxxxxxxx> > > TI DS90Ux9xx de-/serializers have a capability to multiplex pin functions, > in particular a pin may have selectable functions of GPIO, GPIO line > transmitter, one of I2S lines, one of RGB24 video signal lines and so on. > > The change adds a description of DS90Ux9xx pin multiplexers and GPIO > controllers. > > Signed-off-by: Vladimir Zapolskiy <vladimir_zapolskiy@xxxxxxxxxx> (...) > +- gpio-ranges: Mapping to pin controller pins (as described in > + Documentation/devicetree/bindings/gpio/gpio.txt) > + > +Optional properties: > +- ti,video-depth-18bit: Sets video bridge pins to RGB 18-bit mode. > + > +Available pins, groups and functions (reference to device datasheets): Please reference the generic binding you're using here: Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt Apart from these small nitpicks it looks very standard and good. Yours, Linus Walleij
