On Sun, Oct 07, 2018 at 02:20:33PM -0700, Richard Cochran wrote: > On Sun, Oct 07, 2018 at 11:14:05PM +0200, Andrew Lunn wrote: > > I'm currently thinking register_mii_timestamper() should take a netdev > > argument, and the net_device structure should gain a struct > > mii_timestamper. We are going round in circles on this point. V1 had it this way, but nobody liked it. You specifically asked to move the new pointer out of the netdev and into phydev. > > But we have to look at the lifetime problems. A phydev does not know > > what netdev it is associated to until phy_connect() is called. It is > > at that point you can call register_mii_timestamper(). I had used a netdev notifier on NETDEV_UP for this, but Florian seemed to suggest using phy_{connect,attach,disconnect} instead. Thanks, Richard