On Sun, Oct 07, 2018 at 08:27:51PM +0200, Andrew Lunn wrote: > The mii_timestamper is generic, in the same why hwmon is generic. It > does not matter where the time stamper is. So i'm wondering if we > should remove the special case for a PHY timestamper, remove all the > phylib support, etc. This implementation is (to the best of my understanding) what you were asking for in your review of v1: > So i really think you need to cleanly integrate into phylib and > phylink. > Use a phandle, and have > of_mdiobus_register_phy() follow the phandle to get the device. > To keep lifecycle issues simple, i would also keep it in phydev, not > netdev. This present series is a reasonable, incremental improvement to the existing PHY time stamping support. It will handle any use case that I can think of, and I would like to avoid over-engineering this. Thanks, Richard
