(added some cc's)
On Fri, 2014-03-07 at 15:41 -0500, David Miller wrote:
> From: Alistair Popple <alistair@xxxxxxxxxxxx>
> Date: Thu, 6 Mar 2014 14:52:25 +1100
>
> > + out_be32(dev->reg, in_be32(dev->reg) | WKUP_ETH_RGMIIEN
> > + | WKUP_ETH_TX_OE | WKUP_ETH_RX_IE);
>
> When an expression spans multiple lines, the lines should end with
> operators rather than begin with them.
That's not in CodingStyle currently.
Right now, checkpatch emits a --strict only warning on "&&" or "||"
at the beginning of line but that could be changed to any "$Operators"
our $Arithmetic = qr{\+|-|\*|\/|%};
our $Operators = qr{
<=|>=|==|!=|
=>|->|<<|>>|<|>|!|~|
&&|\|\||,|\^|\+\+|--|&|\||$Arithmetic
}x;
The ones that likely have a too high false positive rates
are the negation "!" and bitwise "~".
Also, using perl, it's hard to distinguish between a
logical "&" and the address-of "&" as well as the
multiplication "*" and indirection "*" so maybe those
should be excluded too.
And I think it should only be added as a --strict test.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
