Re: [PATCH 1/2] spi: Add a DT binding for high-impedance turn-around

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Sep 28, 2018 at 3:18 PM Mark Brown <broonie@xxxxxxxxxx> wrote:
> On Tue, Sep 25, 2018 at 04:32:19PM +0200, Linus Walleij wrote:
> > Some 3WIRE SPI devices require the host to insert a
> > "high-impedance turn-around" essentially a clock pulse after
> > switching the one line from output to input.
>
> > +- spi-3wire-high-impedance-turn-around - Empty property indicating that a
> > +                 3wire host need to insert a high-impedance turn-around
> > +                 clock cycle after turning the one output line into an
> > +                 input line.
>
> Should this not be a flag set through the API rather than a DT property?
> It doesn't look like something that's per system configurable but rather
> something that the device is always going to need to do so every single
> usage of the device is going to need this property.

Good point. Let me take it for a spin using some flag inside Linux
instead and see if it looks better.

Yours,
Linus Walleij



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux