On Thu, Sep 27, 2018 at 12:20 AM Al Cooper <alcooperx@xxxxxxxxx> wrote: > > This driver enables USB OHCI on Broadcom ARM and MIPS STB SoCs. > The drivers depend on a matching "brcm,brcmstb-usb-phy" > Broadcom STB USB Phy driver. > > The standard platform driver can't be used because of differences > in PHY and Clock handling. The standard PHY handling in hcd.c will > do a phy_exit/phy_init on suspend/resume and this will end up > shutting down the PHYs to the point that the host controller > registers are no longer accessible and will cause suspend to crash. > The clocks specified in device tree for these drivers are not > available in mainline so instead of returning EPROBE_DEFER when > the specified clock is not found and eventually failing probe, > the clock pointer is set to NULL which disables all clock handling. Both of these sound like fairly minor differences, I wonder if the generic code could be adapted to have a special case for these rather than duplicating it. Arnd