Hi Boris, Thanks for the review. > -----Original Message----- > From: Borislav Petkov [mailto:bp@xxxxxxxxx] > Sent: Friday, September 21, 2018 2:46 PM > To: Manish Narani <MNARANI@xxxxxxxxxx> > Cc: robh+dt@xxxxxxxxxx; mark.rutland@xxxxxxx; mchehab@xxxxxxxxxx; > Michal Simek <michals@xxxxxxxxxx>; leoyang.li@xxxxxxx; > sudeep.holla@xxxxxxx; amit.kucheria@xxxxxxxxxx; > devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux- > edac@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx > Subject: Re: [PATCH v7 2/7] edac: synps: Add platform specific structures for > ddrc controller > > There's more: > > I said: > > > > @@ -370,12 +398,12 @@ static int synps_edac_init_csrows(struct > > > mem_ctl_info *mci) > > > That function returns 0 unconditionally. Make it a void in a prepatch. > > But you've lumped this change together with a bunch more. Maybe my request > wasn't clear so let me rephrase it: > > That function returns 0 unconditionally. Make it a void in a *separate* > prepatch. > > Ok? Yes, okay. 😊 I will keep it in a separate prepatch in v8. Thanks, Manish
