Hi Boris, Thanks for your continuous guidance. > -----Original Message----- > From: Borislav Petkov [mailto:bp@xxxxxxxxx] > Sent: Tuesday, September 18, 2018 1:25 PM > To: Manish Narani <MNARANI@xxxxxxxxxx> > Cc: robh+dt@xxxxxxxxxx; mark.rutland@xxxxxxx; mchehab@xxxxxxxxxx; > Michal Simek <michals@xxxxxxxxxx>; leoyang.li@xxxxxxx; > sudeep.holla@xxxxxxx; amit.kucheria@xxxxxxxxxx; > devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux- > edac@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx > Subject: Re: [PATCH v7 2/7] edac: synps: Add platform specific structures for > ddrc controller > > On Mon, Sep 17, 2018 at 07:55:00PM +0530, Manish Narani wrote: > > Add platform specific structures, so that we can add different IP > > support later using quirks. > > > > Signed-off-by: Manish Narani <manish.narani@xxxxxxxxxx> > > --- > > drivers/edac/synopsys_edac.c | 91 > > +++++++++++++++++++++++++++++++------------- > > 1 file changed, 65 insertions(+), 26 deletions(-) > > ... > > > @@ -423,6 +465,7 @@ static void edac_mc_init(struct mem_ctl_info *mci, > > */ > > static int synps_edac_mc_probe(struct platform_device *pdev) { > > + const struct synps_platform_data *p_data; > > struct edac_mc_layer layers[2]; > > struct synps_edac_priv *priv; > > struct mem_ctl_info *mci; > > @@ -435,7 +478,8 @@ static int synps_edac_mc_probe(struct > platform_device *pdev) > > if (IS_ERR(baseaddr)) > > return PTR_ERR(baseaddr); > > > > - if (!edac_get_eccstate(baseaddr)) { > > + p_data = of_device_get_match_data(&pdev->dev); > > + if (!(p_data->get_eccstate(baseaddr))) { > > From last review round: > > "Too many parentheses: > > if (!p_data->... > > is enough." > > So I'm going to stop reviewing this patchset until you go through the old review > round again and make sure you've incorporated *all* review feedback and > haven't forgotten some, like the one above. > Okay, I will double check again for the comments from previous review and rectify the same in v8. Can you please review the remaining patches so that I can accommodate any changes for them in v8? I regret the inconvenience caused to you in this. Thanks, Manish
