Hi Boris, Thanks a lot for the review. > -----Original Message----- > From: Borislav Petkov [mailto:bp@xxxxxxxxx] > Sent: Tuesday, September 18, 2018 1:23 PM > To: Manish Narani <MNARANI@xxxxxxxxxx> > Cc: robh+dt@xxxxxxxxxx; mark.rutland@xxxxxxx; mchehab@xxxxxxxxxx; > Michal Simek <michals@xxxxxxxxxx>; leoyang.li@xxxxxxx; > sudeep.holla@xxxxxxx; amit.kucheria@xxxxxxxxxx; > devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux- > edac@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx > Subject: Re: [PATCH v7 1/7] edac: synopsys: Fix code comments and naming > convention > > On Mon, Sep 17, 2018 at 07:54:59PM +0530, Manish Narani wrote: > > Update the comments in the Synopsys EDAC driver. Minor changes to > > function names and return types are also included. > > > > Signed-off-by: Manish Narani <manish.narani@xxxxxxxxxx> > > --- > > drivers/edac/synopsys_edac.c | 176 > > ++++++++++++++++++++----------------------- > > 1 file changed, 80 insertions(+), 96 deletions(-) > > So this patch does a bunch of things together and should be split into: > > * functional changes like code cleanup > * functions renaming > * comments cleanup > > Maybe in that order. > > This way you'll have one logical set of changes per patch and review will be > almost trivial. > Okay, I will do that in v8. Thanks, Manish
