On Thu, Sep 20, 2018 at 9:28 AM Bartosz Golaszewski <brgl@xxxxxxxx> wrote: > 2018-09-10 9:05 GMT+02:00 Linus Walleij <linus.walleij@xxxxxxxxxx>: > > On Thu, Sep 6, 2018 at 6:29 PM Bartosz Golaszewski <brgl@xxxxxxxx> wrote: > >> 2018-09-05 15:26 GMT+02:00 Vincent Whitchurch <vincent.whitchurch@xxxxxxxx>: > > > >> > + ret = of_property_read_u32(node, "nr-gpios", &nr_gpios); > >> > >> In addition to what Linus already said: I think this is a good moment > >> to get rid of the platform data structure and instead use device > >> properties, what do you think? > > > > If you're thinking of fwnode that will not work with static platform devices > > (such as add with board files or other random platform_device_register() etc) > > The fwnode concept only works with DT and ACPI. > > I was thinking about using generic device properties: add property > entries with platform_device_add_properties() and read them with > device_property_read_*() functions. Is there any reason this wouldn't > work? Oh I never used that. So I can't tell. It looks neat from a few grep commands. This occupies a space similar to fwnode in my perception so I start to feel there are so many ways to do things now I get all confused. Yours, Linus Walleij
