On Thu, Sep 6, 2018 at 6:29 PM Bartosz Golaszewski <brgl@xxxxxxxx> wrote: > 2018-09-05 15:26 GMT+02:00 Vincent Whitchurch <vincent.whitchurch@xxxxxxxx>: > > + ret = of_property_read_u32(node, "nr-gpios", &nr_gpios); > > In addition to what Linus already said: I think this is a good moment > to get rid of the platform data structure and instead use device > properties, what do you think? If you're thinking of fwnode that will not work with static platform devices (such as add with board files or other random platform_device_register() etc) The fwnode concept only works with DT and ACPI. Yours, Linus Walleij