Re: [PATCH] arm64: dts: renesas: r8a779{7|8}0: add TPU support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 9/21/2018 10:35 AM, Simon Horman wrote:

Describe TPU in the R8A779{7|8}0 device trees.

Based on the original (and large) patches by Vladimir Barinov.

Signed-off-by: Vladimir Barinov <vladimir.barinov@xxxxxxxxxxxxxxxxxx>
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx>

---
This patch is against the 'renesas-devel-20180919-v4.19-rc4' branch of
Simon Horman's 'renesas.git' repo.

  arch/arm64/boot/dts/renesas/r8a77970.dtsi |    8 ++++++++
  arch/arm64/boot/dts/renesas/r8a77980.dtsi |    9 +++++++++
  2 files changed, 17 insertions(+)

Index: renesas/arch/arm64/boot/dts/renesas/r8a77970.dtsi
===================================================================
--- renesas.orig/arch/arm64/boot/dts/renesas/r8a77970.dtsi
+++ renesas/arch/arm64/boot/dts/renesas/r8a77970.dtsi
@@ -614,6 +614,14 @@
  			status = "disabled";
  		};
+ tpu: pwm@e6e80000 {
+			compatible = "renesas,tpu-r8a77970", "renesas,tpu";

   Oops, forgot to document the SoC specific binding...

I'm still not seeing the binding in my inbox.
> Could you post it or point me to a link to it?

Because I still haven't posted it. It turned out the bindings doc needs some fixing 1st... :-/

+			reg = <0 0xe6e80000 0 0x100>;

This register range seems a little small.
 From my reading of the documentation 0x148 would be a more obvious choice.

   Yeah, I've noticed that too -- will be fixed in v2.

Is the driver only accessing registers in in the 0x100 range for some
reason?

   Yes, the registers beyond 0x100 are for the step motor control...

[...]

MBR, Sergei



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux