On Thu, Sep 20, 2018 at 05:45:07PM -0700, Guenter Roeck wrote: > On 09/20/2018 05:07 PM, Nicolin Chen wrote: > > +- ti,channel1-name: > > +- ti,channel2-name: > > +- ti,channel3-name: > > + The names of the input sources (described in the schematics) > > + Set the names with "NC" to indicate not-connected channels > > + > > I don't really think this is a good idea - first to specify sensor > names this way, and much less specifying that "NC" means that a sensor > shall be disconnected/disabled. I will replace the NC with a bool property for disconnection. > Also, if we define devicetree support for this chip, it should include > all configuration options required to configure it. This should at > the very least include shunt resistor values. I plan to add them too but am doing it incrementally. I can try to include them in the next version. Thanks Nicolin
