On 9/20/2018 3:54 PM, Neil Armstrong wrote: > On 20/09/2018 09:09, Jianxin Pan wrote: >> Try to add basic DT support for the Amlogic's Meson-G12A S905D2 SoC, >> which describe components as follows: Reserve Memory, CPU, GIC, IRQ, >> Timer, UART. It's capable of booting up into the serial console. >> >> Signed-off-by: Jianxin Pan <jianxin.pan@xxxxxxxxxxx> >> Reviewed-by: Jerome Brunet <jbrunet@xxxxxxxxxxxx> >> --- >> arch/arm64/boot/dts/amlogic/Makefile | 1 + >> arch/arm64/boot/dts/amlogic/meson-g12a-u200.dts | 22 +++ >> arch/arm64/boot/dts/amlogic/meson-g12a.dtsi | 172 ++++++++++++++++++++++++ [...] >> +#include "meson-g12a.dtsi" >> + >> +/ { >> + compatible = "amlogic,u200", "amlogic,g12a"; >> + model = "Amlogic Meson G12A U200 Development Board"; >> + >> + aliases { >> + serial0 = &uart_AO; >> + }; > > Hi Jianxin, > > Please add the /memory and /chosen nodes. > > + chosen { > + stdout-path = "serial0:115200n8"; > + }; > + > + memory@0 { > + device_type = "memory"; > + reg = <0x0 0x0 0x0 0x40000000>; > + }; > > Thanks, > Neil > > Hi Neil Thanks for the review! I will add them. >> +}; >> + >> +&uart_AO { >> + status = "okay"; >> +}; >> + > [...] > > . >