Re: [PATCH] powerpc/mpc85xx: fix issues in clock node

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2018-09-11 at 10:12 +0800, andy.tang@xxxxxxx wrote:
> From: Yuantian Tang <andy.tang@xxxxxxx>
> 
> The compatible string is not correct in the clock node.
> The clocks property refers to the wrong node too.
> This patch is to fix them.
> 
> Signed-off-by: Tang Yuantian <andy.tang@xxxxxxx>
> ---
>  arch/powerpc/boot/dts/fsl/t1023si-post.dtsi |    8 ++++----
>  1 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/powerpc/boot/dts/fsl/t1023si-post.dtsi
> b/arch/powerpc/boot/dts/fsl/t1023si-post.dtsi
> index 4908af5..763caf4 100644
> --- a/arch/powerpc/boot/dts/fsl/t1023si-post.dtsi
> +++ b/arch/powerpc/boot/dts/fsl/t1023si-post.dtsi
> @@ -348,7 +348,7 @@
>  		mux0: mux0@0 {
>  			#clock-cells = <0>;
>  			reg = <0x0 4>;
> -			compatible = "fsl,core-mux-clock";
> +			compatible = "fsl,qoriq-core-mux-2.0";
>  			clocks = <&pll0 0>, <&pll0 1>;
>  			clock-names = "pll0_0", "pll0_1";
>  			clock-output-names = "cmux0";
> @@ -356,9 +356,9 @@
>  		mux1: mux1@20 {
>  			#clock-cells = <0>;
>  			reg = <0x20 4>;
> -			compatible = "fsl,core-mux-clock";
> -			clocks = <&pll0 0>, <&pll0 1>;
> -			clock-names = "pll0_0", "pll0_1";
> +			compatible = "fsl,qoriq-core-mux-2.0";
> +			clocks = <&pll1 0>, <&pll1 1>;
> +			clock-names = "pll1_0", "pll1_1";
>  			clock-output-names = "cmux1";
>  		};
>  	};

These are the legacy nodes.  Why not just remove them instead of fixing them? 
Now that the cpufreq driver is fixed we could get rid of the legacy nodes for
all the chips.

-Scott




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux