Hi Yogesh, On Mon, 17 Sep 2018 15:18:26 +0530 Yogesh Gaur <yogeshnarayan.gaur@xxxxxxx> wrote: > + > + /* > + * R/W functions for big- or little-endian registers: > + * The FSPI controller's endianness is independent of > + * the CPU core's endianness. So far, although the CPU > + * core is little-endian the FSPI controller can use > + * big-endian or little-endian. > + */ > + if (of_property_read_bool(np, "big-endian")) { > + f->write = fspi_writel_be; > + f->read = fspi_readl_be; > + } else { > + f->write = fspi_writel; > + f->read = fspi_readl; > + } Hm, isn't it something you can extract from the compatible string? I'd rather not allow users to set that in their DT if it's not something you can change. Regards, Boris