Hi Laurent, On Fri, Sep 14, 2018 at 11:24:32AM +0300, Laurent Pinchart wrote: > Hi Jacopo, > > On Friday, 14 September 2018 11:00:46 EEST jacopo mondi wrote: > > On Tue, Sep 04, 2018 at 03:10:14PM +0300, Laurent Pinchart wrote: > > > On the D3 and E3 SoCs, the LVDS encoder can derive its internal pixel > > > clock from an externally supplied clock, either through the EXTAL pin or > > > through one of the DU_DOTCLKINx pins. Add corresponding clocks to the DT > > > bindings. > > > > > > To retain backward compatibility with DT that don't specify the > > > clock-names property, the functional clock must always be specified > > > first, and the clock-names property is optional when only the functional > > > clock is specified. > > > > > > Signed-off-by: Laurent Pinchart > > > <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx> > > > --- > > > > > > .../devicetree/bindings/display/bridge/renesas,lvds.txt | 12 ++++++- > > > 1 file changed, 11 insertions(+), 1 deletion(-) > > > > > > diff --git > > > a/Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt > > > b/Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt index > > > 13af7e2ac7e8..9e3913f6a643 100644 > > > --- a/Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt > > > +++ b/Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt > > > @@ -19,7 +19,17 @@ Required properties: > > > - "renesas,r8a77995-lvds" for R8A77995 (R-Car D3) compatible LVDS > > > encoders > > > > > > - reg: Base address and length for the memory-mapped registers > > > > > > -- clocks: A phandle + clock-specifier pair for the functional clock > > > +- clocks: A list of phandles + clock-specifier pairs, one for each entry > > > in > > > + the clock-names property. > > > +- clock-names: Name of the clocks. This property is model-dependent. > > > + - The functional clock is mandatory for all models, shall be listed > > > first, > > > > I would write > > > > The functional clock, which is mandatory for all models, shall be listed > > first and shall be named "fck". > > I'll change that. > > > > + and shall be named "fck". > > > + - On R8A77990 and R8A77995, the LVDS encoder can use the EXTAL or > > > + DU_DOTCLKINx clocks. Those clocks are optional. When supplied they > > > must be > > > + named "extal" and "dclkin.x" respectively, with "x" being the > > > DU_DOTCLKIN > > > + numerical index. > > > > Is it valid to list other clocks here for the other SoCs? > > No, those clocks only exist for D3 and E3, as stated (R8A77990 and R8A77995). > Do you think the text isn't clear enough ? It's fine. I now read it as: "On R8A77990 and R8A77995 _only_, the LVDS encoder can use the EXTAL or" It's all good, with the little "which" added to the first statement please add to v2: Reviewed-by: Jacopo Mondi <jacopo+renesas@xxxxxxxxxx> Thanks j > > > > + - When the clocks property only contains the functional clock, the > > > + clock-names property may be omitted. > > > > > > - resets: A phandle + reset specifier for the module reset > > > > Thanks > > j > > > > > Required nodes: > > -- > Regards, > > Laurent Pinchart > > >
Attachment:
signature.asc
Description: PGP signature
