On 09/11/2018 10:05 PM, Pavel Machek wrote: > On Tue 2018-09-11 12:08:20, Dan Murphy wrote: >> Remove support for the LM3697 LED device >> from the ti-lmu. The LM3697 will be supported >> via a stand alone LED driver. >> >> Signed-off-by: Dan Murphy <dmurphy@xxxxxx> > > I'd really like to see better explanation here. > > We have existing binding, for lm3697 and similar devices. With this > series, different binding is introduced, without documented reason. > > That's bad. > > Now, maybe you are right and the hardware should be handled by > drivers/leds, not drivers/mfd. But we should have solution for all the > similar chips, and that still does not mean we have to modify the > binding. (But maybe we want to move it to different > directory). Bindings are supposed to describe hardware, not mirror > structure of our drivers. > > Unless there's something fatally wrong with the binding... but in such > case we'd like to know what is wrong. Dangling references ? > [And yes, I recognize current situation is ... not ideal and I'm > willing to help. But I'm not sure this is step in right direction.] > > Thanks, -- Best regards, Jacek Anaszewski
